Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudformation-include): can't use CFN intrinsics in Tags #30515

Merged
merged 9 commits into from
Sep 10, 2024

Conversation

comcalvi
Copy link
Contributor

Issue # (if applicable)

Closes #27594.

Reason for this change

Templates that use intrinsics in resource Tags cannot be used with CFN Include.

Description of changes

Modifed the CFN Parser to not choke on Intrinsics found in resource Tags.

Description of how you validated changes

Unit tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 11, 2024 00:03
@github-actions github-actions bot added bug This issue is a bug. p1 labels Jun 11, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 11, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review June 11, 2024 15:28

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 11, 2024
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but could you add an additional test for an intrinsic that uses other intrinsics within it or just a more complex one in general?

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 11, 2024
@KyleBS
Copy link

KyleBS commented Jul 9, 2024

@TheRealAmazonKendra Any chance we get this merged as-is to fix the issue for the simple case at the very least?

@comcalvi comcalvi dismissed TheRealAmazonKendra’s stale review September 10, 2024 21:44

Comments have been addressed

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d5e47e1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Sep 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit af9e6ba into main Sep 10, 2024
11 of 12 checks passed
@mergify mergify bot deleted the comcalvi/fn-if branch September 10, 2024 22:15
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: CfnParser can't correctly parse conditional Tags
6 participants