Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redshift): supports excludeCharacters settings for DatabaseSecret #30563

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Jun 16, 2024

Issue # (if applicable)

Closes #26847.

Reason for this change

In the case of passwords generated by DatabaseSecret, there may be a need to exclude certain characters.

The original issue was to exclude the backtick character from passwords.
However, the current default value of excludeCharacters, '"@/\ '', matches the characters that are not supported in Redshift (docs).

It can use any ASCII characters with ASCII codes 33–126, except ' (single quotation mark), " (double quotation mark), , /, or @.

Instead of including the backtick in the default value of excludeCharacters, it was considered appropriate to make it configurable.

Description of changes

Add excludeCharacters property to specify characters to not include in generated passwords.

Description of how you validated changes

Add unit tests and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 16, 2024 14:01
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jun 16, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 16, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ea3ebfb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-redshift-alpha: remove backtick ` from the user passwords
2 participants