-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag) #30610
fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag) #30610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
const handlerSourceWithoutComments = handlerSource.replace(/^ *#.*\n?/gm, ''); | ||
|
||
if (handlerSourceWithoutComments.length > 4096) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inline function code can now exceed 4096 bytes. It can support up to 4MB now.
Latest public documentation: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-lambda-function-code.html#cfn-lambda-function-code-zipfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedbacks
packages/@aws-cdk/custom-resource-handlers/lib/aws-s3/notifications-resource-handler/index.py
Show resolved
Hide resolved
packages/@aws-cdk/custom-resource-handlers/lib/aws-s3/notifications-resource-handler/index.py
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-s3/lib/notifications-resource/notifications-resource.ts
Outdated
Show resolved
Hide resolved
@mergify update |
☑️ Nothing to do
|
@mergify update |
☑️ Nothing to do
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…nts-notifications
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@Mergifyio refresh |
✅ Pull request refreshed |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #28915
Reason for this change
Fix to address the issues deleting the existing S3 event notifications and adding new event notifications on top of existing notifications.
Description of changes
We fixed the hashing logic used to identify old vs external S3 event notifications
Description of how you validated changes
Manually tested, integration and unit tested the changes
yes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license