Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs-patterns): support NLB with TLS listener and target group #30611

Merged
merged 22 commits into from
Oct 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d83e8ee
feat: Add props for NLB TLS certificate
199911 Jun 19, 2024
bae669f
test: Add unit test for listenerCertificate
199911 Jun 19, 2024
dd71d68
test: Automatically set listener and target group port to 443 if cert…
199911 Jun 19, 2024
343b55d
docs: Update Readme
199911 Jun 20, 2024
d7c577f
test: Add unit test for NetworkLoadBalancedEc2Service
199911 Jun 20, 2024
13b8cfb
docs: Update Readme
199911 Jun 20, 2024
5d9b9e0
test: Add integration test for nlb with ecs
199911 Jun 20, 2024
97f742b
test: Add integration test for nlb with fargate
199911 Jun 20, 2024
0d6ec3f
fixup! test: Add integration test for nlb with ecs
199911 Jun 21, 2024
d3a847f
fixup! test: Add integration test for nlb with ecs
199911 Aug 15, 2024
1046b3e
fixup! test: Add integration test for nlb with fargate
199911 Aug 15, 2024
4cb910d
Merge branch 'main' into issue-8517-pr
199911 Aug 15, 2024
e943fe2
Merge branch 'main' into issue-8517-pr
199911 Aug 31, 2024
36736a1
Merge branch 'main' into issue-8517-pr
199911 Sep 10, 2024
e3fed8a
Speed up integration test by importing cert from arn
199911 Sep 30, 2024
eb57c44
Update fargate snapshot
199911 Sep 30, 2024
19977fe
Merge branch 'main' into issue-8517-pr
199911 Sep 30, 2024
65769ae
Update ec2 snapshot
199911 Sep 30, 2024
129043c
Add certificate set up to framework-integ/README.md
199911 Oct 11, 2024
aab64ef
Merge branch 'main' into issue-8517-pr
199911 Oct 11, 2024
303f5b1
Minor fix on README
199911 Oct 11, 2024
153b7f7
Merge branch 'main' into issue-8517-pr
mergify[bot] Oct 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/@aws-cdk-testing/framework-integ/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,18 @@ See `integ-runner` package or `yarn integ --help` for detailed instructions.

## Common Errors

### Error: For this test you must provide your own HostedZoneId/HostedZoneName/DomainName
### Error: For this test you must provide your own HostedZoneId/HostedZoneName/DomainName/Certificate

Some test cases require a publicly available domain name attached to a Amazon Route 53 Hosted Zone to work.
These test cases need to add DNS records that are then retrieved via the public internet infrastructure. This can be a subdomain to an existing domain, but it must have a Hosted Zone configured and nameservers delegated to it.

If you haven't got one ready, see the [Route 53 guide](https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/CreatingHostedZone.html) to manually create a hosted zone.

Some test cases require an ACM public certificate on a publicly available domain name to work.
These test cases need a public certificate which uses DNS for domain ownership validation.

See the [AWS Certificate Manager guide](https://docs.aws.amazon.com/acm/latest/userguide/acm-public-certificates.html) to request an Amazon-Issued certificate.

AWS CDK core team members, please check our team internal docs for guidance on how to configure domains for testing.

#### How to correctly run these tests
Expand All @@ -25,12 +30,15 @@ The checked-in snapshot uses dummy values that will not deploy.

- Go to your Hosted Zone and write down the values for `HostedZoneId`, `HostedZoneName` and `DomainName`.
All values must related to the **same** Hosted Zone.
- Go to your AWS Certificate Manager and write down the ARN for the `Certificate`
The certificate should be attached to a domain name in the **same** Hosted Zone.
- In your terminal run the following commands:

```console
export HOSTED_ZONE_ID=your_hosted_zone_id
export HOSTED_ZONE_NAME=your_hosted_zone_name
export DOMAIN_NAME=your_domain_name
export CERT_ARN=your_certificate_arn
```

- Finally, in the same terminal run your specific test case with the **update workflow disabled**. For example:
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading