Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(eks): corrected documentation for KubernetesVersion.V1_30 property #30614

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

ashishdhingra
Copy link
Contributor

Issue # (if applicable)

Closes #30613.

Reason for this change

Documentation for KubernetesVersion.V1_30 property incorrectly refers to KubectlV29Layer.

Description of changes

Corrected documentation for KubernetesVersion.V1_30 property to refer to KubectlV30Layer.

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Corrected documentation for KubernetesVersion.V1_30 property to refer to `KubectlV30Layer`.
@ashishdhingra ashishdhingra requested a review from pahud June 21, 2024 15:56
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort p2 labels Jun 21, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 21, 2024 15:56
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@ashishdhingra
Copy link
Contributor Author

Exemption Request
This is a doc only change.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jun 21, 2024
@TheRealAmazonKendra
Copy link
Contributor

TheRealAmazonKendra commented Jun 21, 2024

The title for this is not quite correct. Please see the pull request section of our contributing guide for proper titling of Pull Requests.

Once you have corrected the title, you will not need an exemption.

Also the build failure here looks completely unrelated so I'll retrigger it for you to see if we can get it working.

@ashishdhingra ashishdhingra changed the title fix(eks): Corrected documentation for KubernetesVersion.V1_30 property. docs(eks): Corrected documentation for KubernetesVersion.V1_30 property. Jun 21, 2024
@ashishdhingra
Copy link
Contributor Author

The title for this is not quite correct. Please see the pull request section of our contributing guide for proper titling of Pull Requests.

Once you have corrected the title, you will not need an exemption.

Also the build failure here looks completely unrelated so I'll retrigger it for you to see if we can get it working.

Thanks. I have corrected the title.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c911ffb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ashishdhingra ashishdhingra changed the title docs(eks): Corrected documentation for KubernetesVersion.V1_30 property. docs(eks): Corrected documentation for KubernetesVersion.V1_30 property Jun 21, 2024
@ashishdhingra ashishdhingra changed the title docs(eks): Corrected documentation for KubernetesVersion.V1_30 property docs(eks): corrected documentation for KubernetesVersion.V1_30 property Jun 21, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 21, 2024 19:20

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Jun 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d1d217f into main Jun 21, 2024
22 of 25 checks passed
@mergify mergify bot deleted the ashishdhingra-eks-KubectlV30Layer branch June 21, 2024 19:20
This was referenced Jun 24, 2024
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eks: typo in code doc
4 participants