feat(apigatewayv2-integrations): WebSocketMockIntegration props
#30622
Conversation
github-actions
bot
added
distinguished-contributor
| /** | ||
| * A map of Apache Velocity templates that are applied on the request | ||
| * payload. | ||
| * | ||
| * ``` | ||
| * { "application/json": "{ \"statusCode\": 200 }" } | ||
| * ``` | ||
| * | ||
| * @default - No request template provided to the integration. | ||
| * @see https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-websocket-api-mapping-template-reference.html | ||
| */ | ||
| readonly requestTemplates?: { [contentType: string]: string }; |
There was a problem hiding this comment.
Previous discussion: https://github.com/aws/aws-cdk/pull/29661/files#r1649290535
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request: |
aws-cdk-automation
added
the
pr-linter/exemption-requested
nmussy
force-pushed
the
feat-apigatewayv2-mock-props
branch
from
989beee
to
24dde44
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
| * A map of Apache Velocity templates that are applied on the request | ||
| * payload. | ||
| * | ||
| * ``` |
aws-cdk-automation
added
pr/needs-maintainer-review
I don't think this is a good enough reasoning. Some documentation should have been added when this construct is initially added. Would you please add somethiing to the README to explain the usage and what this is for? Appreciate it. |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
1 similar comment
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
Issue # (if applicable)
None
Reason for this change
Unlike the other integrations,
WebSocketMockIntegrationdid not have a props interface, and was missing a few properties. This PR does not include integration responses, they are already being implemented in #29661Description of changes
requestTemplatesandtemplateSelectionExpressionto the newly createdWebSocketMockIntegrationPropsDescription of how you validated changes
Unit and integration tests were updated
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license