Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events): dead letter queue for an Event Bus #30628

Merged
merged 22 commits into from
Oct 19, 2024
Merged

feat(events): dead letter queue for an Event Bus #30628

merged 22 commits into from
Oct 19, 2024

Conversation

badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Jun 23, 2024 •
edited
Loading

Issue # (if applicable)

Closes #30531.

Reason for this change

EventBus L2 construct doesn't support for configuring dead letter queue.

Description of changes

Add deadLetterQueue prop to EventBusProps

Description of how you validated changes

Add both unit and integ test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jun 23, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 23, 2024 04:55
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jun 23, 2024
@badmintoncryer badmintoncryer changed the title feat(events): dead letter queue configuration of a Event Bus feat(events): dead letter queue configuration for an Event Bus Jun 23, 2024
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. labels Jun 23, 2024
@badmintoncryer badmintoncryer marked this pull request as ready for review June 23, 2024 12:33
@github-actions github-actions bot mentioned this pull request Jun 24, 2024
Closed
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 24, 2024
@badmintoncryer badmintoncryer changed the title feat(events): dead letter queue configuration for an Event Bus feat(events): dead letter queue for an Event Bus Jun 24, 2024
@msambol
Copy link
Contributor

msambol commented Jun 28, 2024

Small nits re: the naming, otherwise LGTM.

@badmintoncryer
Copy link
Contributor Author

@msambol Thank you for your review!! I've addressed your comments.

@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

2 similar comments
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@badmintoncryer
Copy link
Contributor Author

@msambol Hi, I've fixed this PR. Could you please re-review this?

mazyu36
mazyu36 approved these changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A community review was already done, but since there had been no activity for a long time, I reviewed it again

@badmintoncryer
Copy link
Contributor Author

@mazyu36 Thank you very much for your kindness!!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e652263
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 19, 2024
moelasmar
moelasmar approved these changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@moelasmar moelasmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 318eae6 into aws:main Oct 19, 2024
18 checks passed
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 19, 2024
@badmintoncryer badmintoncryer deleted the dlqForEventbus branch October 19, 2024 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@msambol msambol msambol left review comments

@moelasmar moelasmar moelasmar approved these changes

@mazyu36 mazyu36 mazyu36 approved these changes

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

events: support dead letter queue for the event bus
5 participants
@badmintoncryer @msambol @aws-cdk-automation @mazyu36 @moelasmar