fix(scheduler-targetes-alpha): multiple schedules cause resolution error during synth #30634
Conversation
github-actions
bot
added
the
valued-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Tietew
changed the title
Tietew
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
Tietew
force-pushed
the
scheduler-targets-fix-resolution-error
branch
from
6f9766a
to
f6004ff
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Reason for this change
Creating multiple
Schedules causes Resolution Error during synth.This PR does not fix the root cause (discussing at #28713), but apply a workaround to prevent the error.
Description of changes
Use
ServicePrincipalwith conditions directly, instead ofPrincipalWithConditions.Description of how you validated changes
Added a feature flag
{"@aws-cdk/aws-iam:minimizePolicies":true}to unit tests.Resolution errors occur before fix. No errors occur after fix.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license