feat(location): support Map #30648
feat(location): support Map #30648
Conversation
github-actions
bot
added
star-contributor
| export enum CustomLayer { | ||
| /** | ||
| * The POI custom layer adds a richer set of places, such as shops, services, restaurants, attractions, and other points of interest to your map. | ||
| * Currently only the VectorEsriNavigation map style supports the POI custom layer. |
There was a problem hiding this comment.
I considered adding this validation, but decided against it as I thought the scope might expand in the future, potentially making it unnecessary. Please provide any opinions if you have them.
| /** | ||
| * An India (IND) political view | ||
| */ | ||
| INDIA = 'IND', |
There was a problem hiding this comment.
According to docs, political view can only be used with specific styles. However, considering the possibility that future AWS updates might expand its applicability, I have decided not to add validation at this time.
Please provide any feedback if you have any.
mazyu36
force-pushed
the
location-service-map
branch
from
6945287
to
9d9b731
Compare
aws-cdk-automation
added
the
pr/needs-community-review
mazyu36
force-pushed
the
location-service-map
branch
from
c65cae2
to
91e92e2
Compare
…x class (#30974) ### Issue # (if applicable) N/A ### Reason for this change Add validation for PlaceIndex description, similar to #30648, #30682, and #30711 . ### Description of changes Add validation and unit tests for description. ### Description of how you validated changes Add unit tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
| })).toThrow('`description` must be between 0 and 1000 characters. Received: 1001 characters'); | ||
| }); | ||
|
|
||
| test('throws with invalid name', () => { |
There was a problem hiding this comment.
How about adding the test about invalid name length?
There was a problem hiding this comment.
Thanks. I've added a test.
Also I've refactored the code to separate the regex pattern check and length check, as I think it would be more user-friendly.
aws-cdk-automation
removed
the
pr/needs-community-review
|
@badmintoncryer |
aws-cdk-automation
added
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #30647.
Reason for this change
In aws-location-alpha,
maphas not been supported yet.Description of changes
Add
Mapclass.Description of how you validated changes
Add a unit test and a integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license