Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipes-targets): add Kinesis #30656

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Jun 25, 2024

Add Kinesis data stream as a Pipes target.

It's nontrivial to get the data from the Kinesis data stream, but here are screenshots
showing data made it through during the integration test.

Screenshot 2024-06-24 at 7 24 10 PM Screenshot 2024-06-24 at 7 26 35 PM

@github-actions github-actions bot added the p2 label Jun 25, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 25, 2024 02:01
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jun 25, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 25, 2024
Copy link
Contributor

@nmussy nmussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, should be good to go otherwise

packages/@aws-cdk/aws-pipes-targets-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 25, 2024
@msambol
Copy link
Contributor Author

msambol commented Jun 25, 2024

@nmussy Updated as well. Thanks again!

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

This was referenced Jul 1, 2024
@pahud pahud added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 578997d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants