Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: fix(core): overrideLogicalId validation #30695

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

TheRealAmazonKendra
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra commented Jun 27, 2024

Reverts #29708 due to #30669

Closes #30669

@aws-cdk-automation aws-cdk-automation requested a review from a team June 27, 2024 16:40
@github-actions github-actions bot added the p2 label Jun 27, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 27, 2024
@TheRealAmazonKendra TheRealAmazonKendra changed the title revert: "fix(core): overrideLogicalId validation" revert: fix(core): overrideLogicalId validation Jun 27, 2024
@TheRealAmazonKendra TheRealAmazonKendra added p0 and removed p2 labels Jun 27, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0acb590
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jun 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0aa2be7 into main Jun 27, 2024
37 checks passed
@mergify mergify bot deleted the revert-29708-fix-core-overrideLogicalId-validation branch June 27, 2024 17:09
scanlonp pushed a commit that referenced this pull request Jun 27, 2024
This was referenced Jul 1, 2024
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p0
Projects
None yet
3 participants