Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipes-targets): add SageMaker #30696

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(pipes-targets): add SageMaker #30696

wants to merge 6 commits into from
+34,491 −0

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Jun 27, 2024

Add SageMaker pipeline as a Pipes target.

@aws-cdk-automation aws-cdk-automation requested a review from a team June 27, 2024 17:20
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jun 27, 2024
@msambol msambol mentioned this pull request Jun 27, 2024
Merged
@aws-cdk-automation aws-cdk-automation added pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 27, 2024
mergify bot pushed a commit that referenced this pull request Jun 28, 2024
@msambol
chore(docs): correct spelling for pipeline (#30697)
afe69b8 
I saw these errors when working on #30696.
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 29, 2024
nmussy
nmussy suggested changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@nmussy nmussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall 👍

packages/@aws-cdk/aws-pipes-targets-alpha/lib/sagemaker.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/sagemaker.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/sagemaker.ts Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 29, 2024
This was referenced Jul 1, 2024
Closed
Closed
@msambol
Copy link
Contributor Author

msambol commented Jul 1, 2024

@nmussy – updated per your feedback. Thanks as always!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 16dce83
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pahud pahud added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmussy nmussy nmussy requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msambol @aws-cdk-automation @nmussy @pahud