Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag) #30706

Merged
merged 32 commits into from
Jul 2, 2024
Merged

fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag) #30706

merged 32 commits into from
Jul 2, 2024

Conversation

sarangarav
Copy link
Contributor

@sarangarav sarangarav commented Jun 28, 2024 •
edited
Loading

Issue # (if applicable)

Closes #28915

Reason for this change

Fix to address the issues deleting the existing S3 event notifications and adding new event notifications on top of existing notifications.

Description of changes

We fixed the hashing logic used to identify old vs external S3 event notifications

Description of how you validated changes

Manually tested, integration and unit tested the changes

yes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Raviteja Saranga and others added 24 commits June 21, 2024 01:51
Bug fix to address the issues deleting existing S3 event notifications
cbdf720
Bug fix to address the issues with deleting existing S3 event notific…
e882c5c 
…ations
Bug fix to address the issues with deleting existing S3 event notific…
d4861bb 
…ations
@sarangarav
Merge branch 'main' into feature/s3-lambda-events-notifications
a2dbea9
@sarangarav
Merge branch 'main' into feature/s3-lambda-events-notifications
0bcda02
Bug fix to address the issues with deleting existing S3 event notific…
87f5b6b 
…ations
Update S3-notification integ tests snapshot
fc233f8
Update S3-notification integ tests snapshot
3d4190c
Update S3 notification resource handler
52f4e8a
Fix S3 event notifications lint errors
e666f0a
Update S3-notification integ tests
00aad4a
Update S3 event notification integ tests
8c6971f
Merge origin/main into feature/s3-lambda-events-notifications and res…
08ce15f 
…olved conflicts
Fix the S3 event notifications issues
c506d5e
S3 notification resource handler updates
0d4af78
S3 event notification integ tests update
3c8804b
Update s3 notification integ tests
dbb04b7
Update S3 event notifications integ tests
10b804c
Merge remote-tracking branch 'origin/main' into feature/s3-lambda-eve…
841dce1 
…nts-notifications
@sarangarav
Merge branch 'main' into feature/s3-lambda-events-notifications
30d5dce
@sarangarav
Merge branch 'main' into feature/s3-lambda-events-notifications
e85abcc
@GavinZZ
Merge branch 'main' into feature/s3-lambda-events-notifications
b586a30
@sarangarav
Merge branch 'aws:main' into feature/s3-lambda-events-notifications
762e1ff
Fix feature flag related issues
7e5c088
@aws-cdk-automation aws-cdk-automation requested a review from a team June 28, 2024 20:17
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Jun 28, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 28, 2024
This was referenced Jul 1, 2024
Closed
Closed
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f39ae7a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Reposit