Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new partitions and regions #30737

Merged
merged 54 commits into from
Jul 5, 2024

Conversation

TheRealAmazonKendra
Copy link
Contributor

Note that the docstring in aws-entities states that the regions are added in the order they went live. For several, that was not accurate so I reordered them. This is unlikely to matter but I made the change so that the documentation there would be factually correct.

Not all of these regions/partitions are live yet, but they have been announced here

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jul 2, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 2, 2024 19:28
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 2, 2024
@aws aws deleted a comment from scanlonp Jul 2, 2024
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheRealAmazonKendra TheRealAmazonKendra force-pushed the TheRealAmazonKendra/add-partitions branch 7 times, most recently from 92efd81 to 46ea8b8 Compare July 4, 2024 22:47
@TheRealAmazonKendra TheRealAmazonKendra force-pushed the TheRealAmazonKendra/add-partitions branch from 46ea8b8 to 15c75e1 Compare July 5, 2024 00:37
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6a47142
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 5, 2024
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s go!!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 5, 2024
@TheRealAmazonKendra
Copy link
Contributor Author

@Mergifyio update

@TheRealAmazonKendra TheRealAmazonKendra merged commit 76c140d into main Jul 5, 2024
17 checks passed
@TheRealAmazonKendra TheRealAmazonKendra deleted the TheRealAmazonKendra/add-partitions branch July 5, 2024 17:22
@TheRealAmazonKendra
Copy link
Contributor Author

Manually merged due to mergify outage today

Copy link
Contributor

mergify bot commented Jul 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jul 5, 2024

update

❌ Base branch update has failed

head ref does not exist

Copy link
Contributor

mergify bot commented Jul 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants