Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logs): support regex patterns for JSON Metrics filters #30741

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jan-xyz
Copy link

@jan-xyz jan-xyz commented Jul 3, 2024

Issue # (if applicable)

Closes #30451

Reason for this change

Support Regex in filter functions for JSON

Description of changes

Adding a new JSONPattern factory that uses % instead of " to support the regex pattern.

Description of how you validated changes

I tried it in our own CDK code.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jul 3, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 3, 2024 08:15
@jan-xyz jan-xyz changed the title Support regex patterns Support regex patterns for JSON Metrics filters Jul 3, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@jan-xyz jan-xyz changed the title Support regex patterns for JSON Metrics filters feat(logs): Support regex patterns for JSON Metrics filters Jul 3, 2024
@jan-xyz jan-xyz changed the title feat(logs): Support regex patterns for JSON Metrics filters feat(logs): support regex patterns for JSON Metrics filters Jul 3, 2024
@jan-xyz
Copy link
Author

jan-xyz commented Jul 3, 2024

Clarification Request: How should the snapshot look like? It seems that this package doesn't have any yet? According to INTEGRATION_TEST.md there should be a integ.mtericfilter.js.snapshot/ directory but I couldn't find it.

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Jul 3, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 93ddc8e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@jan-xyz
Copy link
Author

jan-xyz commented Jul 25, 2024

I had a question how to do the integration test, and I am still waiting on the response

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
@paulhcsun
Copy link
Contributor

paulhcsun commented Aug 7, 2024

Hi @jan-xyz, apologies for missing this clarification request. The integration tests for modules in aws-cdk-lib are located in the aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-logs/test directory: https://github.com/aws/aws-cdk/tree/main/packages/%40aws-cdk-testing/framework-integ/test/aws-logs/test

Please refer to this section of our INTEGRATION_TESTS.md.

@paulhcsun paulhcsun reopened this Aug 7, 2024
@paulhcsun paulhcsun added pr-linter/do-not-close The PR linter will not close this PR while this label is present and removed closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run labels Aug 7, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr-linter/do-not-close The PR linter will not close this PR while this label is present
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-logs: Allow JSON filter patterns to use regex by removing automatic double quotes around pattern strings
3 participants