Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipes-targets): add API Gateway #30772

Closed
wants to merge 8 commits into from
Closed

feat(pipes-targets): add API Gateway #30772

wants to merge 8 commits into from

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Jul 6, 2024

Add API Gateway REST API as a Pipes target.

@github-actions github-actions bot added the p2 label Jul 6, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 6, 2024 23:41
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jul 6, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 7, 2024
nmussy
nmussy suggested changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@nmussy nmussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs don't explicitly mention that the target can only be a REST API, it might work with WebSockets? If that's the case, could you add an integ and the likes?

packages/@aws-cdk/aws-pipes-targets-alpha/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/api-gateway.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/api-gateway.ts Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/test/integ.api-gateway.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 7, 2024
@msambol
Copy link
Contributor Author

msambol commented Jul 7, 2024 •
edited
Loading

The docs don't explicitly mention that the target can only be a REST API, it might work with WebSockets? If that's the case, could you add an integ and the likes?

Good shout about the docs. I did create a WebSocket API and it wasn't available in the Console when I tried to create a Pipe target. The CFN docs do state only REST APIs. @redwheeler3, can you confirm if REST APIs are the only type supported here?

msambol
msambol commented Jul 7, 2024
View reviewed changes
packages/@aws-cdk/aws-pipes-targets-alpha/lib/api-gateway.ts
grantPush(grantee: IRole): void {
grantee.addToPrincipalPolicy(new PolicyStatement({
resources: [this.restApiArn],
actions: ['execute-api:Invoke'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmussy updated this to just Invoke

msambol
msambol commented Jul 7, 2024
View reviewed changes
packages/@aws-cdk/aws-pipes-targets-alpha/test/integ.api-gateway.ts
'x-header': 'myheader',
},
queryStringParameters: { key: 'USA' },
pathParameterValues: ['fiction'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmussy I think this is what you're after? fiction replaces the * in path defined above. More coverage..

@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Closed
@redwheeler3
Copy link

Good shout about the docs. I did create a WebSocket API and it wasn't available in the Console when I tried to create a Pipe target. The CFN docs do state only REST APIs. @redwheeler3, can you confirm if REST APIs are the only type supported here?

Pipes does not support WebSocket APIs.

@msambol
Copy link
Contributor Author

msambol commented Jul 8, 2024

Good shout about the docs. I did create a WebSocket API and it wasn't available in the Console when I tried to create a Pipe target. The CFN docs do state only REST APIs. @redwheeler3, can you confirm if REST APIs are the only type supported here?

Pipes does not support WebSocket APIs.

The ManageConnections permission can be removed from the role created by the Console.

@msambol msambol force-pushed the pipes-targets-api-gw branch 2 times, most recently from a254134 to a253bc6 Compare July 10, 2024 15:48
@pahud pahud added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024
@pahud pahud added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 22, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 22, 2024
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 78b663c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

3 similar comments
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Oct 28, 2024
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nmussy nmussy nmussy requested changes

Assignees
No one assigned
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msambol @redwheeler3 @aws-cdk-automation @nmussy @pahud