Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda): inline code size limit is 4MB #30773

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Jul 7, 2024

Issue # (if applicable)

Closes #30761.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort labels Jul 7, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 7, 2024 00:23
@github-actions github-actions bot added the p2 label Jul 7, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 7, 2024
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a massive in-line code size, but not out of the question.

Looks like there used to be a character restriction on inline code based on some old stackoverflow answers, but that may have been removed.

I would like to see if an inline lambda will deploy with more than 4kb. The template being synthesized is not a good indicator of whether it works or not since it would be a CFN limit that we do not validate currently.

@msambol
Copy link
Contributor Author

msambol commented Jul 21, 2024

This seems like a massive in-line code size, but not out of the question.

Looks like there used to be a character restriction on inline code based on some old stackoverflow answers, but that may have been removed.

I would like to see if an inline lambda will deploy with more than 4kb. The template being synthesized is not a good indicator of whether it works or not since it would be a CFN limit that we do not validate currently.

I changed it to be the resulting zip file cannot exceed 4MB. I think that's the only limit we can deduce from the docs?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cc26be6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@scanlonp
Copy link
Contributor

Hey @msambol, I am doing some work with lambda assets, so I will give this a spin. I still think this may be an error in their documentation. The limit for a CFN template as a whole uploaded to s3 is 1 MB (CFN limits).

I'd love to be wrong here, but I am feeling lucky with this prediction! I'll get back to you shortly.

@msambol
Copy link
Contributor Author

msambol commented Sep 5, 2024

@scanlonp Any update on this one?

@msambol
Copy link
Contributor Author

msambol commented Sep 29, 2024

@scanlonp Thoughts here? Should I close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cdk.aws_lambda.Code: from_inline method code size limit incorrect
3 participants