docs(events): improved maintenance of information on supported targets #30785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
star-contributor
aws-cdk-automation
added
the
pr/needs-community-review
scanlonp
reviewed
Jul 9, 2024
scanlonp
approved these changes
Jul 9, 2024
aws-cdk-automation
removed
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
GavinZZ
pushed a commit
that referenced
this pull request
Jul 10, 2024
#30785) ### Reason for this change Information about targets supported by `aws-events-targets` is also listed in `aws-events`, but this information is outdated and can be confusing to users. Aggregating the list of supported targets in `aws-events-targets` will prevent contributors from forgetting to update it. ### Description of changes Add a message to the README of `aws-events` encouraging people to look at `aws-events-targets` for information on targets. ### Description of how you validated changes ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
Information about targets supported by
aws-events-targetsis also listed inaws-events, but this information is outdated and can be confusing to users.Aggregating the list of supported targets in
aws-events-targetswill prevent contributors from forgetting to update it.Description of changes
Add a message to the README of
aws-eventsencouraging people to look ataws-events-targetsfor information on targets.Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license