Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cognito-identitypool-alpha): allowUnauthenticatedIdentities still creates an unauthenticated IAM role #30884

Closed
wants to merge 3 commits into from

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented Jul 18, 2024

Issue # (if applicable)

Closes #25470.

Description of changes

Prevent to create an unauthenticated role when allowUnauthenticatedIdentities is not true.

Description of how you validated changes

Updated unit tests to validate expected roles are created.
Updated an integ test to create an identity pool with allowUnauthenticatedIdentities: false.

Checklist

BREAKING CHANGE: The IdentityPool.unauthenticatedRole attribute is now optional. You may need to add non-null assertion on it. On update a stack, an unauthenticated role will be deleted unless allowUnauthenticatedRole is true.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 18, 2024 07:29
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Jul 18, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 18, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4af5eec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@Leo10Gama
Copy link
Member

Thanks for the contribution! Unfortunately, these changes will not be needed, since the behaviour outlined in the original issue is actually expected.

@Leo10Gama Leo10Gama closed this Aug 29, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@aws-cdk/aws-cognito-identitypool-alpha: allowUnauthenticatedIdentities still creates IAM role
3 participants