Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: issue and pull requests permissions #30894

Merged
merged 2 commits into from
Jul 18, 2024
Merged

chore: issue and pull requests permissions #30894

merged 2 commits into from
Jul 18, 2024

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Jul 18, 2024 •
edited
Loading

add required permissions

Issue # (if applicable)

Closes #.

Reason for this change

Description of changes

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 18, 2024 23:18
@github-actions github-actions bot added the p2 label Jul 18, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 18, 2024
kellertk
kellertk requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@kellertk kellertk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should move the permissions block to under the jobs block, where the current permissions block is.

kellertk
kellertk approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@kellertk kellertk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e3c0764 into main Jul 18, 2024
13 checks passed
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9aeb7ec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot deleted the pahud-patch-2 branch July 18, 2024 23:50
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this pull request Jul 22, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kellertk kellertk kellertk approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pahud @aws-cdk-automation @kellertk