Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lock conversations on closed issues and PRs with message #30941

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Jul 24, 2024

Issue # (if applicable)

Reason for this change

Lock conversations on closed issues and PRs to make sure important comments are not left on closed items and no one would be able to see it. Force people to create new issues instead.

Description of changes

Lock conversations.

Description of how you validated changes

Tested in a forked repo and it works correctly.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jul 24, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 24, 2024 18:06
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 24, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@GavinZZ GavinZZ changed the title chore: Lock closed issues and PRs with message chore: lock closed issues and PRs with message Jul 24, 2024
@GavinZZ GavinZZ changed the title chore: lock closed issues and PRs with message chore: lock conversations on closed issues and PRs with message Jul 24, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 24, 2024 18:10

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@GavinZZ GavinZZ marked this pull request as ready for review July 24, 2024 18:37
@moelasmar
Copy link
Contributor

it looks good to me. The only thing is missed, and I do not think we need to add it as GH workflow is to do lock all old closed issues and PRs, as this workflow will work only for newly closed issues or prs

Copy link
Contributor

mergify bot commented Jul 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 64afa72 into main Jul 24, 2024
11 of 12 checks passed
Copy link
Contributor

mergify bot commented Jul 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the lock_pr_with_conversation branch July 24, 2024 19:33
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ec11fd7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2024
message: |
Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line should be removed, I think community will not be able to add comments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I missed this line while reviewing the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good point. Let me remove it.

@GavinZZ GavinZZ added p1 and removed p2 labels Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants