Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ses): corrected default value as true for ConfigurationSet.reputationMetrics property #30979

Merged

Conversation

ashishdhingra
Copy link
Contributor

Issue # (if applicable)

Closes #30968.

Reason for this change

The default value of ConfigurationSet.reputationMetrics if not set in the CDK stack is actually true (refer #30968 (comment) for details).

Description of changes

Corrected default value as true for ConfigurationSet.reputationMetrics property in documentation comment.

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 29, 2024 23:16
@github-actions github-actions bot added effort/small Small work item – less than a day of effort p2 labels Jul 29, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 29, 2024
@pahud
Copy link
Contributor

pahud commented Jul 30, 2024

Thank you. Based on your verification on the console #30968 (comment) leaving it undefined would make it enabled by CFN so I think this PR should be good.

LGTM but I'll let the maintainer to approve.

@Leo10Gama Leo10Gama self-assigned this Jul 30, 2024
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed on my end as well that it defaults to true in the console, thank you!

Copy link
Contributor

mergify bot commented Jul 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 30, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b32991b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d60aaa0 into main Jul 30, 2024
14 of 15 checks passed
Copy link
Contributor

mergify bot commented Jul 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the user/ashdhin/ses-docs-configurationset-reputationmetrics branch July 30, 2024 22:06
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-ses): ConfigurationSet.reputationMetrics incorrect default value
4 participants