-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fix asset bundling for nested stack with exclusive flag #30983
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Clarification Request: i have test case implemented, not sure what else is it asking here. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Exemption Request |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
Issue #30967
Closes #30967
Reason for this change
Incorrect bundling required check for child stack return by the function
Description of changes
The current nested stack used parent stack's inherited function which cause incorrect assessment
More details description:
this.node.path
used is Stage/Stack1/StackNested, however the context it validate against is only "Stage/Stack1". the current function do not validate against child stack's stack name. To fix this, i simply have the child stack call the parent stack, and if the root stack is match then all child stack will be marked as bundling required.Description of how you validated changes
Implemented via test driven approach, validate by test case
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license