Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): add support for 8.0.mysql_aurora.3.07.1 #30990

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

Andrwe
Copy link
Contributor

@Andrwe Andrwe commented Jul 31, 2024

(description based on #30479)

Reason for this change

Add support for newly supported 8.0.mysql_aurora.3.07.1.
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraMySQLReleaseNotes/AuroraMySQL.Updates.3071.html

Description of changes

Add a new version as a new property to AuroraMysqlEngineVersion class.

Description of how you validated changes

I used the AWS CLI to verify that the new version is available.

$ aws rds describe-db-engine-versions --engine aurora-mysql --query "DBEngineVersions[?EngineVersion=='8.0.mysql_aurora.3.07.1']"
[
    {
        "Engine": "aurora-mysql",
        "EngineVersion": "8.0.mysql_aurora.3.07.1",
        "DBParameterGroupFamily": "aurora-mysql8.0",
        "DBEngineDescription": "Aurora MySQL",
        "DBEngineVersionDescription": "Aurora MySQL 3.07.1 (compatible with MySQL 8.0.36)",
        "ValidUpgradeTarget": [],
        "ExportableLogTypes": [
            "audit",
            "error",
            "general",
            "slowquery"
        ],
        "SupportsLogExportsToCloudwatchLogs": true,
        "SupportsReadReplica": false,
        "SupportedEngineModes": [
            "provisioned"
        ],
        "SupportedFeatureNames": [
            "Bedrock"
        ],
        "Status": "available",
        "SupportsParallelQuery": true,
        "SupportsGlobalDatabases": true,
        "MajorEngineVersion": "8.0",
        "SupportsBabelfish": false,
        "SupportsLimitlessDatabase": false,
        "SupportsCertificateRotationWithoutRestart": true,
        "SupportedCACertificateIdentifiers": [
            "rds-ca-2019",
            "rds-ca-ecc384-g1",
            "rds-ca-rsa4096-g1",
            "rds-ca-rsa2048-g1"
        ],
        "SupportsLocalWriteForwarding": true,
        "SupportsIntegrations": true
    }
]

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: Andreas Ulm <andreas.ulm@prisma-capacity.eu>
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jul 31, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 31, 2024 14:56
@github-actions github-actions bot added the p2 label Jul 31, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Andrwe
Copy link
Contributor Author

Andrwe commented Jul 31, 2024

Exemption Request

I request an exemption from the rules regarding README, test files and integration tests as this PR only adds support for a new version of AuroraMySQLEngineVersion to be up-to-date to versions supported by AWS Aurora service.
Therefore no functionality is added, changed or removed that IMHO needs additional testing.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 31, 2024
Signed-off-by: Andreas Ulm <andreas.ulm@prisma-capacity.eu>
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 18f8a86
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@xazhao
Copy link
Contributor

xazhao commented Aug 2, 2024

This change could be categorized as chore so it's exempted from integration test automatically.

@xazhao xazhao changed the title feat(rds): add support for 8.0.mysql_aurora.3.07.1 chore(rds): add support for 8.0.mysql_aurora.3.07.1 Aug 2, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 2, 2024 18:43

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Aug 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 51ee4dc into aws:main Aug 2, 2024
14 of 15 checks passed
Copy link

github-actions bot commented Aug 2, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 2, 2024
@Andrwe Andrwe deleted the add_version_VER_3_07_1 branch August 5, 2024 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants