Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: npm-check-updates && yarn upgrade #30991

Merged
merged 24 commits into from
Sep 11, 2024
Merged

chore: npm-check-updates && yarn upgrade #30991

merged 24 commits into from
Sep 11, 2024

Conversation

aws-cdk-automation
Copy link
Collaborator

Ran npm-check-updates and yarn upgrade to keep the yarn.lock file up-to-date.

@aws-cdk-automation aws-cdk-automation added auto-approve contribution/core This is a PR that came from AWS. dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. labels Jul 31, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 31, 2024 17:41
@aws-cdk-automation aws-cdk-automation requested a review from a team July 31, 2024 17:41
@github-actions github-actions bot added the p2 label Jul 31, 2024
This was referenced Aug 1, 2024
Open
Closed
@b177y b177y mentioned this pull request Aug 7, 2024
Closed
1 task
@scanlonp
Copy link
Contributor

This is failing because ajv v8.17.1 replaced uri-js with fast-uri. In aws-cdk-lib/NOTICE we have uri-js and not fast-uri.

Do not know why the automation missed this. Maybe manual intervention is necessary here.

@aws-cdk-automation @github-actions
chore: npm-check-updates && yarn upgrade
48ad732 
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bee1d25
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e91eec2 into main Sep 11, 2024
10 of 12 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the automation/yarn-upgrade branch September 11, 2024 01:58
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scanlonp scanlonp scanlonp left review comments

@github-actions GitHub Actions github-actions approved these changes

Assignees
No one assigned
Labels
auto-approve contribution/core This is a PR that came from AWS. dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aws-cdk-automation @scanlonp @rix0rrr @moelasmar