Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(opensearchservice): fix broken Markdown due to an invisible char #31007

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

exalted
Copy link
Contributor

@exalted exalted commented Aug 2, 2024

Issue # (if applicable)

Closes #.

Reason for this change

For some invisible char in the Markdown, it wasn't rendered correctly.

Description of changes

I am unsure what was there, but replacing the "space" between ## and Enable with a regular space (i.e., ' ') fixed it.

Description of how you validated changes

After this change, using the Markdown preview feature in my editor, as well as regular Markdown syntax highlighting, worked as expected.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

I am unsure what was there, but replacing the "space" between `##` and `Enable` with a regular space (i.e., ' ') fixed it
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Aug 2, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team August 2, 2024 10:05
@github-actions github-actions bot added the p2 label Aug 2, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@exalted exalted changed the title Fix broken Markdown due to an invisible char docs(opensearchservice): fix broken Markdown due to an invisible char Aug 2, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 2, 2024 10:08

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 2, 2024
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Aug 2, 2024
Copy link
Contributor

mergify bot commented Aug 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 2, 2024
Copy link
Contributor

mergify bot commented Aug 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@xazhao
Copy link
Contributor

xazhao commented Aug 6, 2024

@mergify update

Copy link
Contributor

mergify bot commented Aug 6, 2024

update

✅ Branch has been successfully updated

Copy link
Contributor

mergify bot commented Aug 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a7a12e7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 71f07e4 into aws:main Aug 7, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Aug 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

github-actions bot commented Aug 7, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants