Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(glue): introduction of AWS Glue Workflow L2 Construct #31014

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Rizxcviii
Copy link
Contributor

@Rizxcviii Rizxcviii commented Aug 2, 2024

Issue # (if applicable)

Closes #31010.

Reason for this change

Now including the L2 construct that was part of the original RFC

Description of changes

Included the workflow.ts file, and it's test files.

Description of how you validated changes

Unit test, Integration testing

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Aug 2, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team August 2, 2024 22:09
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Rizxcviii Rizxcviii changed the title feat(aws-glue): Introduction of AWS Glue Workflow L2 Construct feat(aws-glue): introduction of AWS Glue Workflow L2 Construct Aug 2, 2024
@Rizxcviii Rizxcviii changed the title feat(aws-glue): introduction of AWS Glue Workflow L2 Construct feat(glue): introduction of AWS Glue Workflow L2 Construct Aug 2, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 5, 2024 11:07

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 5, 2024
@natalie-white-aws
Copy link

This conflicts with the refactor PR and RFC pending review here #30833

@Rizxcviii
Copy link
Contributor Author

Hi @natalie-white-aws, since you've already included this in your PR, would it be safe to assume I should close this PR? Since the workflow construct has been developed in your refactor?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c9a225b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-glue: Addition of Glue Workflow
3 participants