Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow all sts options for roles assumed by the cli #31089

Merged
merged 94 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
4f7a820
WIP: add placeholder integ test
sumupitchayan Aug 12, 2024
d02e7d2
WIP: CLI bootstrap integ test is passing, even though it should be fa…
sumupitchayan Aug 12, 2024
e50a57c
cleanup comments in app.js
sumupitchayan Aug 12, 2024
9f2e54b
Integ test now 'successfully' fails as intended; switched session tag…
sumupitchayan Aug 12, 2024
da3ee2b
add principaltag to deployrole policy
sumupitchayan Aug 13, 2024
2720e81
WIP: make framework changes
sumupitchayan Aug 13, 2024
52c049e
Merge branch 'main' into sumughan/session-tags
sumupitchayan Aug 13, 2024
0595021
add session tags to cloud assembly schema, fixing compiler errors
sumupitchayan Aug 13, 2024
47e947b
WIP: CLI changes in sdk-provider
sumupitchayan Aug 13, 2024
35a2c86
Integ test successfully failing
sumupitchayan Aug 14, 2024
53a70ee
add tags to lambda stack
sumupitchayan Aug 14, 2024
c6ba899
fix department session tag in app.js example
sumupitchayan Aug 14, 2024
7fd801b
WIP: update CFN schema, add session tags prop in different places
sumupitchayan Aug 15, 2024
bc3f498
TEMP FIX - to use local source version of aws-cdk-lib in cli integ tests
sumupitchayan Aug 15, 2024
b36fb70
remove commented out code in app.js
sumupitchayan Aug 16, 2024
9cdcd24
remove changes to cx-api/lib/artifacts/cloudformation-artifact.ts
sumupitchayan Aug 16, 2024
7197399
add tags to file asset role in integ test
sumupitchayan Aug 16, 2024
1d361bf
Update packages/@aws-cdk-testing/cli-integ/resources/cdk-apps/app/app.js
sumupitchayan Aug 19, 2024
c529bd9
Update packages/@aws-cdk-testing/cli-integ/resources/cdk-apps/app/app.js
sumupitchayan Aug 19, 2024
f195dee
typo: rename sessiontagslambdastack
sumupitchayan Aug 19, 2024
a4e3736
Add (and assert on) session tags for the docker image role in Integ t…
sumupitchayan Aug 19, 2024
7a3a80e
Add session tags to core README
sumupitchayan Aug 19, 2024
de1e557
WIP: add custom synthesizer integ test which is succeeding when it SH…
sumupitchayan Aug 20, 2024
1ec5f87
WIP
sumupitchayan Aug 20, 2024
251287b
add assumeRoleSessionTags to CloudFormationStackArtifact
sumupitchayan Aug 20, 2024
0ad122f
add assumeRoleSessionTags to ClientOptions interfact in cdk-assets/
sumupitchayan Aug 20, 2024
f86fe91
WIP: custom synth integ test now deploys! (without session tags in bo…
sumupitchayan Aug 20, 2024
2365552
add Session Tag conditional to Lambda policy statement - integ test n…
sumupitchayan Aug 20, 2024
05d2b79
add assumeRoleSessionTags inside prepareSdkWithLookupRoleFor function
sumupitchayan Aug 20, 2024
53eb52f
add unit test for aws-cdk-lib/core/lib/stack-synthesizers
sumupitchayan Aug 20, 2024
8927b6a
add lookup role to synth unit test
sumupitchayan Aug 20, 2024
555255f
add Engineering session tag to customsynth integ test stack
sumupitchayan Aug 21, 2024
1cca0e2
missing comma
sumupitchayan Aug 21, 2024
fe327c0
Add TagSession permission to roles in custom bootstrap stacks to make…
sumupitchayan Aug 23, 2024
12e60f6
remove unused imports from app.js
sumupitchayan Aug 23, 2024
6b92bd5
add custom synthesizer in separate file, also unit test for it
sumupitchayan Aug 24, 2024
11195e1
update core README
sumupitchayan Aug 24, 2024
ab9b26c
remove hardcoded path from lib/with-cdk-app.ts
sumupitchayan Aug 24, 2024
45a86d7
remove cdk-assets and cloud-assembly-schema directories
sumupitchayan Aug 24, 2024
4bc8830
add back cloud-assembly-schema dir with README and index.ts
sumupitchayan Aug 24, 2024
40227e2
Merge branch 'main' into sumughan/session-tags
sumupitchayan Aug 24, 2024
e8195d3
Update packages/@aws-cdk-testing/cli-integ/lib/with-cdk-app.ts
sumupitchayan Aug 26, 2024
da43281
add explanation comments inside custom bootstrap templates on TagSess…
sumupitchayan Aug 26, 2024
37a8ad5
Update packages/@aws-cdk-testing/cli-integ/resources/cdk-apps/app/app.js
sumupitchayan Aug 26, 2024
95d990b
Update packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/boot…
sumupitchayan Aug 26, 2024
94dc868
cleanup app.js
sumupitchayan Aug 26, 2024
ad33968
Merge branch 'sumughan/session-tags' of https://github.com/aws/aws-cd…
sumupitchayan Aug 26, 2024
d114fc7
rename CustomSynthesizer to NoExecutionRoleCustomSynthesizer in app.js
sumupitchayan Aug 26, 2024
59c1098
WIP: core README
sumupitchayan Aug 26, 2024
3a7a948
add comment in sdk-provider.ts explaining why we use transitive tag keys
sumupitchayan Aug 26, 2024
2bb8381
remove extra line in cloud-assembly-schema/README.md
sumupitchayan Aug 26, 2024
06de35a
delete custom-synthesizer file, write it inline core unit test instea…
sumupitchayan Aug 26, 2024
ec4b07d
add example using CustomSynthesizer to core README
sumupitchayan Aug 26, 2024
d920463
Merge branch 'main' into sumughan/session-tags
sumupitchayan Aug 26, 2024
278dc4e
add sdk-provider unit test, including adding sessionTags and transiti…
sumupitchayan Aug 26, 2024
1a44756
Merge branch 'sumughan/session-tags' of https://github.com/aws/aws-cd…
sumupitchayan Aug 26, 2024
a8fc420
sts:TagSession to bootstrap template and adjust bootstrap versions re…
iliapolo Aug 28, 2024
b3c62c9
mid work
iliapolo Aug 29, 2024
e5a369e
mid work
iliapolo Sep 1, 2024
2a9ef1f
mid work
iliapolo Sep 1, 2024
d4a43b1
Merge branch 'main' into sumughan/session-tags
iliapolo Sep 1, 2024
67160f1
mid work
iliapolo Sep 2, 2024
a1bfbdf
mid work
iliapolo Sep 2, 2024
d9374a2
mid work
iliapolo Sep 4, 2024
5d7b601
mid work
iliapolo Sep 10, 2024
a51622a
mid work
iliapolo Sep 11, 2024
007f23f
Merge branch 'main' into sumughan/session-tags
iliapolo Sep 11, 2024
30ce9f8
mid work
iliapolo Sep 11, 2024
315b169
test vpc lookup
iliapolo Sep 12, 2024
ff0034d
mid work
iliapolo Sep 12, 2024
8cc1d92
mid work
iliapolo Sep 12, 2024
b24e879
mid work
iliapolo Sep 12, 2024
fc455f1
mid work
iliapolo Sep 12, 2024
ff9b20a
mid work
iliapolo Sep 12, 2024
da2cb72
mid work
iliapolo Sep 12, 2024
1539bfe
mid work
iliapolo Sep 15, 2024
da328ee
mid work
iliapolo Sep 15, 2024
bcdf94f
Merge branch 'main' into sumughan/session-tags
iliapolo Sep 15, 2024
0b47cd7
mid work
iliapolo Sep 15, 2024
0ae1a1b
mid work
iliapolo Sep 15, 2024
f778c2c
Merge branch 'main' into sumughan/session-tags
iliapolo Sep 18, 2024
07137e3
mid work
iliapolo Sep 19, 2024
22b1069
Merge branch 'main' into sumughan/session-tags
iliapolo Sep 19, 2024
4734465
mid work
iliapolo Sep 19, 2024
50ef70f
Merge branch 'main' into sumughan/session-tags
iliapolo Sep 19, 2024
ebce5fe
mid work
iliapolo Sep 20, 2024
d923ec6
Merge branch 'main' into sumughan/session-tags
iliapolo Sep 20, 2024
b32c570
mid work
iliapolo Sep 20, 2024
6e08d60
Merge branch 'main' into sumughan/session-tags
iliapolo Sep 20, 2024
217b08b
Merge branch 'main' into sumughan/session-tags
iliapolo Sep 23, 2024
a33c6e2
mid work
iliapolo Sep 23, 2024
c57f0ba
mid work
iliapolo Sep 23, 2024
4a70851
Merge branch 'main' into sumughan/session-tags
iliapolo Sep 23, 2024
0c753cf
Merge branch 'main' into sumughan/session-tags
mergify[bot] Sep 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/@aws-cdk-testing/cli-integ/lib/with-cdk-app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,11 @@ export async function cloneDirectory(source: string, target: string, output?: No
}

interface CommonCdkBootstrapCommandOptions {
/**
* @default - the default CDK bootstrap template.
sumupitchayan marked this conversation as resolved.
Show resolved Hide resolved
*/
readonly bootstrapTemplate?: string;

readonly toolkitStackName: string;

/**
Expand Down Expand Up @@ -420,6 +425,9 @@ export class TestFixture extends ShellHelper {
if (options.usePreviousParameters === false) {
args.push('--no-previous-parameters');
}
if (options.bootstrapTemplate) {
args.push('--template', options.bootstrapTemplate);
}

return this.cdk(args, {
...options.cliOptions,
Expand Down Expand Up @@ -620,7 +628,7 @@ export async function installNpmPackages(fixture: TestFixture, packages: Record<
}, undefined, 2), { encoding: 'utf-8' });

// Now install that `package.json` using NPM7
await fixture.shell(['node', require.resolve('npm'), 'install']);
await fixture.shell(['node', '/Users/sumughan/Developer/aws-cdk/packages/@aws-cdk-testing/cli-integ/lib/package-sources/repo-tools/npm', 'install']);
sumupitchayan marked this conversation as resolved.
Show resolved Hide resolved
}

const ALREADY_BOOTSTRAPPED_IN_THIS_RUN = new Set();
Loading
Loading