Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): configure Stack SNS notification ARNs on the Stack construct #31107

Merged
merged 69 commits into from
Sep 23, 2024

Conversation

comcalvi
Copy link
Contributor

@comcalvi comcalvi commented Aug 14, 2024

Issue # (if applicable)

#8581.

Reason for this change

It is easier and clearer to specify the SNS Topic ARNs on the stack construct itself instead of passing it as a command line argument.

Description of changes

Added a new optional stack prop, notificationArns, that is written to the CloudAssembly and concatenated with the CLI option --notification-arns.

Don't forget to select stacks by hierarchical ID (currently display name, in our tests) when writing certain test code. Otherwise, the tests may not select the stack you expect.

Depends on: cdklabs/cdk-assets#87 and cdklabs/cloud-assembly-schema#58.

Description of how you validated changes

Unit tests + CLI integ test. Framework integ tests not included because they would require an externally-created SNS Topic, which is not what we want in integ tests; besides, the case is covered by the CLI integ test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

mergify bot pushed a commit to cdklabs/cloud-assembly-schema that referenced this pull request Sep 18, 2024
…ruct (#29)

Adds SNS notification ARNs to the cloud-assembly-schema. Necessary for aws/aws-cdk#31107.
@comcalvi comcalvi changed the title feat(core): configure SNS topics to receive stack events on the Stack construct feat(core): configure Stack SNS notification ARNs on the Stack construct Sep 18, 2024
mergify bot pushed a commit to cdklabs/cdk-assets that referenced this pull request Sep 18, 2024
Bumps the schema to 37.0.0, necessary for: aws/aws-cdk#31107.
@comcalvi comcalvi added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Sep 18, 2024
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@comcalvi comcalvi added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Sep 20, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 20, 2024 16:38

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Sep 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4977203
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1593500 into main Sep 23, 2024
10 of 12 checks passed
Copy link
Contributor

mergify bot commented Sep 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the comcalvi/notification-arns branch September 23, 2024 09:07
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p1 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants