-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): configure Stack SNS notification ARNs on the Stack construct #31107
Conversation
…ruct (#29) Adds SNS notification ARNs to the cloud-assembly-schema. Necessary for aws/aws-cdk#31107.
Bumps the schema to 37.0.0, necessary for: aws/aws-cdk#31107.
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
#8581.
Reason for this change
It is easier and clearer to specify the SNS Topic ARNs on the stack construct itself instead of passing it as a command line argument.
Description of changes
Added a new optional stack prop,
notificationArns
, that is written to the CloudAssembly and concatenated with the CLI option--notification-arns
.Don't forget to select stacks by hierarchical ID (currently display name, in our tests) when writing certain test code. Otherwise, the tests may not select the stack you expect.
Depends on: cdklabs/cdk-assets#87 and cdklabs/cloud-assembly-schema#58.
Description of how you validated changes
Unit tests + CLI integ test. Framework integ tests not included because they would require an externally-created SNS Topic, which is not what we want in integ tests; besides, the case is covered by the CLI integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license