Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(applicationautoscaling): add missing PredefinedMetricType enum values #31115

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

shahks
Copy link
Contributor

@shahks shahks commented Aug 14, 2024

Issue # (if applicable)

Closes #31113

Reason for this change

There are three PredefinedMetricType values missing from the enum:

  • SageMakerInferenceComponentConcurrentRequestsPerCopyHighResolution
  • SageMakerVariantConcurrentRequestsPerModelHighResolution
  • WorkSpacesAverageUserSessionsCapacityUtilization

https://docs.aws.amazon.com/autoscaling/application/APIReference/API_PredefinedMetricSpecification.html

Description of changes

Adds the missing enums

Description of how you validated changes

Added unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 14, 2024 20:23
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Aug 14, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@shahks
Copy link
Contributor Author

shahks commented Aug 14, 2024

updates to README file and integ test file is not necessary as it's only adding enums.

@moelasmar moelasmar changed the title feat(applicationautoscaling): add missing PredefinedMetricType enum v... feat(applicationautoscaling): add missing PredefinedMetricType enum values Aug 14, 2024
@moelasmar moelasmar changed the title feat(applicationautoscaling): add missing PredefinedMetricType enum values chore(applicationautoscaling): add missing PredefinedMetricType enum values Aug 14, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 14, 2024 20:51

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify mergify bot dismissed moelasmar’s stale review August 14, 2024 21:34

Pull request has been modified.

@shahks shahks requested a review from moelasmar August 14, 2024 21:41
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 14, 2024
moelasmar
moelasmar previously approved these changes Aug 17, 2024
Copy link
Contributor

mergify bot commented Aug 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 17, 2024
Copy link
Contributor

mergify bot commented Aug 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed moelasmar’s stale review August 18, 2024 15:43

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 79ef624
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 18, 2024
Copy link
Contributor

mergify bot commented Aug 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c1c800e into aws:main Aug 19, 2024
14 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_applicationautoscaling: Enable SageMaker high resolution predefined metric
3 participants