feat(rds): enable grantDataApiAccess method for imported database cluster

[go-to-k]

Issue # (if applicable)

Closes #31116 .

Reason for this change

It was not possible to call the grantDataApiAccess method for an imported database cluster.

Because the imported database cluster always has the enableDataApi with false.

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-rds/lib/cluster.ts#L983

class ImportedDatabaseCluster extends DatabaseClusterBase implements IDatabaseCluster {
  // ...
  protected readonly enableDataApi = false;

But the grantDataApiAccess throws an error when the enableDataApi is set to false.

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-rds/lib/cluster.ts#L523-L526

  public grantDataApiAccess(grantee: iam.IGrantable): iam.Grant {
    if (this.enableDataApi === false) {
      throw new Error('Cannot grant Data API access when the Data API is disabled');
    }
    // ...
}

Description of changes

Added the property dataApiEnabled to attributes for the imported database cluster.

If the dataApiEnabled to the attributes is set to true, the enableDataApi in the imported cluster will be set to true and the grantDataApiAccess can be called.

Description of how you validated changes

Unit and integ tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[badmintoncryer]

Thank you for the PR! I've added only a nit comment.

I hardcoded enableDataApi as false for the imported cluster, so I really appreciate the fix!

[go-to-k]

Thanks, changed!

[GavinZZ]

LGTM, thanks for the quick response to my question.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: fb7bd65
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.