Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cloudfront): updates to CloudFront ResponseHeadersPolicy XSSProtection #31301

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

awslukeguan
Copy link
Contributor

Issue # (if applicable)

Closes #20962

Reason for this change

Update the documentation to have a deployable example.

Description of changes

Set modeBlock to false when reportUri is set.
You cannot specify a ReportUri when ModeBlock is true.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-responseheaderspolicy-xssprotection.html

Description of how you validated changes

Updated the tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Sep 3, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 3, 2024 14:21
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 3, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 3, 2024
@mergify mergify bot dismissed comcalvi’s stale review September 3, 2024 19:00

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 3, 2024
@kaizencc kaizencc changed the title chore: updated documentation for CloudFront ResponseHeadersPolicy XSSProtection docs(cloudfront): updates to CloudFront ResponseHeadersPolicy XSSProtection Sep 4, 2024
kaizencc
kaizencc previously approved these changes Sep 4, 2024
@mergify mergify bot dismissed kaizencc’s stale review September 4, 2024 14:52

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d9c61a6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Sep 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 511eab3 into aws:main Sep 4, 2024
11 checks passed
Copy link

github-actions bot commented Sep 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudfront example fails deployment
4 participants