Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert(stepfunctions-tasks): "feat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath" #31308

Merged
merged 2 commits into from
Sep 3, 2024
Merged

revert(stepfunctions-tasks): "feat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath" #31308

merged 2 commits into from
Sep 3, 2024

Conversation

Leo10Gama
Copy link
Member

@Leo10Gama Leo10Gama commented Sep 3, 2024 •
edited
Loading

Reverts #30298 to resolve #31302

BREAKING CHANGE: Reverting the original PR will come with the following breaking changes

  • stepfunctions-tasks: The BedrockInvokeModel.outputPath parameter will no longer be an S3Uri

@github-actions github-actions bot added bug This issue is a bug. p0 labels Sep 3, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 3, 2024 20:53
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 3, 2024
@Leo10Gama Leo10Gama marked this pull request as ready for review September 3, 2024 20:54
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Leo10Gama Leo10Gama changed the title Revert "feat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath" chore: Revert "feat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath" Sep 3, 2024
@Leo10Gama Leo10Gama changed the title chore: Revert "feat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath" fix: Revert "feat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath" Sep 3, 2024
@Leo10Gama Leo10Gama changed the title fix: Revert "feat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath" revert: "feat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath" Sep 3, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 3, 2024 20:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@Leo10Gama Leo10Gama added the pr/do-not-merge This PR should not be merged at this time. label Sep 3, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 3, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 3, 2024
@Leo10Gama Leo10Gama changed the title revert: "feat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath" revert(stepfunctions-tasks): "feat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath" Sep 3, 2024
@Leo10Gama Leo10Gama added pr-linter/exempt-breaking-change The PR linter will not require stability in stable modules and removed pr/do-not-merge This PR should not be merged at this time. labels Sep 3, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 3, 2024 21:45

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 3, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 3, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 3, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5b468cb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 842ee15 into main Sep 3, 2024
15 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 3, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the revert-30298-s3_uri_for_bedrock branch September 3, 2024 22:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shikha372 shikha372 shikha372 approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p0 pr-linter/exempt-breaking-change The PR linter will not require stability in stable modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

❗ NOTICE: stepfunctions-tasks: BedrockInvokeModel outputPath no longer passes output to next state
3 participants
@Leo10Gama @aws-cdk-automation @shikha372