fix(ecs): ecs exec cannot be enabled for ECS Anywhere (ecs.ExternalService)

[mazyu36]

Issue # (if applicable)

Closes #31181.

Reason for this change

In the ecs.ExternalService class (ECS Anywhere), the enableExecuteCommand property cannot be set to true, so it is not possible to enable ECS exec.
However, the documentation states that ECS Anywhere supports ECS Exec.

ECS Exec is supported for tasks that run on the following infrastructure:
Linux and Windows containers on external instances (Amazon ECS Anywhere)

Description of changes

Remove unnecessary if statement.

Description of how you validated changes

Fix an unit test.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[mazyu36]

Exemption Request: unable to execute integ test.

To complete the deployment, an external instance such as a VM is required, but I think this is very difficult in integ test.
In a previous PR for the ExternalService implementation, integ test wasn't inclueded.

#14931 (comment)

I tried running the integration test, but since the external instance did not exist, the deployment could not be completed.

During the deployment, I confirmed that the enableExecuteCommand property of the ExternalService was set to true using the CLI, so I would like to consider this as an alternative.

 % aws ecs describe-services --cluster aws-ecs-integ-external-exec-command-ExternalCluster14BF29C2-1WgNGhaSCe6j --service aws-ecs-integ-external-exec-command-ExternalService9AC5437C-yEbQ87UFPByK  --region us-east-1                           
{
    "services": [
        {
            "serviceArn": "arn:aws:ecs:us-east-1:...
             // omit
            "enableExecuteCommand": true
             // omit
}

[go-to-k]

Could you change the description (in your Ec2Service or FargateService) in README?

To enable the ECS Exec feature for your containers, set the boolean flag enableExecuteCommand to true in your Ec2Service or FargateService.

https://github.com/go-to-k/aws-cdk/blob/152f32d887baacecd95d4d3aea7703cb467b1771/packages/aws-cdk-lib/aws-ecs/README.md#ecs-exec-command

[mazyu36]

@go-to-k
Thanks. I've updated.

[go-to-k]

Thank you.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[GavinZZ]

@mergify update

[mergify]

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 32696f4
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.