feat(eks): update nodegroup gpu check

[AlexKaracaoglu]

Issue # (if applicable)

Closes #31347.

Reason for this change

The motivating bug is that you cannot add a combo of g5 and a g6 as instance classes onto the same node group or else the following error will be thrown: instanceTypes of different architectures is not allowed.

Description of changes

• (eks) Fixes the isGpuInstanceType check
  • G6/G6E instance classes will now be recognized as GPU instance types so those different types can be used together for a multi instance type managed node group

Description of how you validated changes

Wrote unit tests for the isGpuInstanceType function

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[lpizzinidev]

Thanks 👍

[sumupitchayan]

Thanks for your PR @AlexKaracaoglu - I think adding an Integ test or modifying and existing one to use this new Instance Type would be nice to confirm that it successfully deploys.

Also, can you add a unit test for the isGpuInstanceType function?

[pahud]

Hi @AlexKaracaoglu

Not sure if you are still on it but you can refer to this commit I made
pahud@8fd3db8

[AlexKaracaoglu]

@pahud @sumupitchayan - Appreciate the follow ups, I'll get some changes in later today

[paulhcsun]

Hi @AlexKaracaoglu, as mentioned by Sumu, could you use the new instance types in an existing integ test? You can refer to this PR for reference: #27373. I can also help to run the integ test if needed once you add the changes.

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

[AlexKaracaoglu]

Hey @paulhcsun - I appreciate the follow up. I added some changes to the integration tests to support the gpu nodegroup case. I am able to partly run the integ tests but cannot perform a real deployment - would you be able to assist me with running/getting the snapshots updated now that the changes are in?

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: f696b9d
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.