-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): set (default) stack termination protection on (parent) stage level #31450
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Turns out I was looking the assertion stack data in the snapshot, not the test stack data which was correct (i.e. had a termination protection enabled) 😄 |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #31449
Closes #31449.
Reason for this change
New feature: Enable setting
Stack
(default) termination protection on (parent)Stage
level.Description of changes
terminationProtection
intoStageProps
Stage
constructor, either use the termination protection value from its props (if set) or inherit from parent stageStack
constructor, either use the termination protection value from its props (if set), or inherit from parent stage, or finally default to false (as before)Description of how you validated changes
I've originally done a PoC in my own codebase (by extending
cdk.Stage
).After modifications into
aws-cdk
codebase:packages/aws-cdk-lib/core/test/stage.test.ts
packages/aws-cdk-lib/core/test/stack.test.ts
packages/@aws-cdk-testing/framework-integ/test/core/test/integ.stage-termination-protection.ts
and updated the snapshotsChecklist
Disclaimers:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license