fix(cognito-identitypool): refactor authentication providers #31482
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request - this is a refactor; seeing no changes to the integ tests is expected |
aws-cdk-automation
added
the
pr-linter/exemption-requested
There are so many proper nouns that are not proper nouns...
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| @@ -179,19 +180,19 @@ new IdentityPool(this, 'myidentitypool', { | |||
| identityPoolName: 'myidentitypool', | |||
| authenticationProviders: { | |||
| amazon: { | |||
| appId: 'amzn1.application.12312k3j234j13rjiwuenf', | |||
| clientId: 'amzn1.application.12312k3j234j13rjiwuenf', | |||
There was a problem hiding this comment.
this seems to be a breaking change though, can we mention in the PR.
packages/@aws-cdk/aws-cognito-identitypool-alpha/lib/identitypool.ts
Outdated
Show resolved
Hide resolved
…ool.ts Co-authored-by: Shikha Aggarwal <shikhaaggarwal1995@gmail.com>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
N/A
Reason for this change
The authentication providers and their logic in this module have bad code smells, and thus, we have refactored them to bring the module more in line with CDK standards and best practices.
Description of changes
deprecatedtag, as the service was deprecated back in 2017.IdentityPoolAuthenticationProvider, as they were incredibly similar aside from slight differences in docstrings and nomenclature.IdentityPoolProvidersandIdentityPoolAuthenticationProvidersinterfaces have been merged, as there did not seem to be a reason to keep them separate, aside from differentiating third-party and internal providers.Description of how you validated changes
Unit tests and integration tests have been tweaked only as necessary to confirm these changes. Since they all still pass or show no need to be updated, we can confirm that this refactor does not affect them.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license