Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda): improve the doc about the code signing in Lambda #31500

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Sep 19, 2024

improve the doc about the code signing

Issue # (if applicable)

Closes #29474

Reason for this change

Singing is still required by user before the deployment. This PR clarifies this in the doc.

Description of changes

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

improve the doc about the code signing
@aws-cdk-automation aws-cdk-automation requested a review from a team September 19, 2024 16:56
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels Sep 19, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 19, 2024
@pahud pahud added @aws-cdk/aws-lambda Related to AWS Lambda contribution/core This is a PR that came from AWS. and removed contribution/core This is a PR that came from AWS. labels Sep 19, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b44f6b6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Sep 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 76e83a5 into main Sep 19, 2024
35 of 36 checks passed
@mergify mergify bot deleted the pahud-patch-3 branch September 19, 2024 17:26
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_lambda: enforced code signing causes deployment failure
3 participants