Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(batch): remove default optimal for arm based instance types and add error checks #31510

Merged
merged 15 commits into from
Oct 1, 2024
Merged

fix(batch): remove default optimal for arm based instance types and add error checks #31510

merged 15 commits into from
Oct 1, 2024

Commits on Sep 20, 2024

  1. initial working solution to bug

    Chen committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    196ac09 View commit details
    Browse the repository at this point in the history

  2. add warning from annotations library

    Chen committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c195f1b View commit details
    Browse the repository at this point in the history

  3. addInstanceType and addInstanceClass architecture compatibility check

    Chen committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    114e835 View commit details
    Browse the repository at this point in the history

  4. test cases for error and warning messages when there is mixed archite… 

    …cture
    Chen committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7184db8 View commit details
    Browse the repository at this point in the history

  5. optimal is not included in when there are arm instances

    Chen committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fe6f2f5 View commit details
    Browse the repository at this point in the history

  6. test cases for addInstanceType and addInstanceClass errors when mixed… 

    … architecture
    Chen committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9f211f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Merge branch 'main' into remove_optimal_for_arm_based_instance_types

    @shikha372
    shikha372 authored Sep 21, 2024
    Configuration menu
    Copy the full SHA
    c1e0012 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. linter changes

    Chen committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    52b1a06 View commit details
    Browse the repository at this point in the history

  2. update integration tests

    Chen committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8d6233d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into remove_optimal_for_arm_based_instance_types

    @1kaileychen
    1kaileychen authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a42e8fe View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. remove changing value useOptimalInstanceClasses & update test cases

    Chen committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e4b2864 View commit details
    Browse the repository at this point in the history

  2. change error to warning for mixed instances & modify test cases

    Chen committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    016a89a View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. remove error message when adding types or classes in case of regressions

    Chen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3d5b53f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into remove_optimal_for_arm_based_instance_types

    @1kaileychen
    1kaileychen authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    bd4ee20 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into remove_optimal_for_arm_based_instance_types

    @mergify
    mergify[bot] authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    43e5c82 View commit details
    Browse the repository at this point in the history