-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eks): support for installing default networking add-ons #31822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @badmintoncryer - you mention adding unit tests in the PR description but I don't see them here?
@sumupitchayan Thanks! I've completely forgotten to add unit test. I've added it. |
new eks.Cluster(this, 'EksCluster', { | ||
vpc, | ||
...getClusterVersionConfig(this, eks.KubernetesVersion.V1_30), | ||
bootstrapSelfManagedAddons: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @badmintoncryer - I see from the CFN docs that by default, the networking addons include vpc-cni, coredns, and kube-proxy. Maybe instead the integ test should pass in bootstrapSelfManagedAddons: false
and assert somehow that the addons were not installed?
@sumupitchayan Apologize for the delay.
I tried to add integ test and noticed that creating an EKS cluster by AWS CDK does not install any add-ons whether or not
Official document says that default add-ons are always installed for the EKS cluster. However, is my understanding correct that when creating an EKS cluster via CDK (eks.Cluster construct), no add-ons are installed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Comments on closed issues and PRs are hard for our team to see. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Issue # (if applicable)
Closes #30804.
Reason for this change
Description of changes
bootstrapSelfManagedAddons
prop toClusterProps
Description of how you validated changes
Add both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license