-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scheduler-alpha): scheduler input always get transformed to string with extra double quotes #31894
Merged
mergify
merged 23 commits into
aws:main
from
samson-keung:scheduler-reduce-key-permissions
Oct 28, 2024
Merged
fix(scheduler-alpha): scheduler input always get transformed to string with extra double quotes #31894
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
ff1e462
reduce key permissions. pending test changes
samson-keung 9025add
update integ test to have less KMS permissions
samson-keung fb485c7
revise schedule integ test to have assertion
samson-keung d6d4a7d
Integ assertion is updated to poll for max 10 messages from SQS
samson-keung 6f0f045
Add missing permission to Schedule to send messages to queue
samson-keung 88dad4f
make assertion wait time less. 5 minutes
samson-keung 1447087
update schedule time so that they do not get invoked
samson-keung 5b81a3e
fix input fromText has extra quotations
samson-keung 37091ff
update snapshot
samson-keung cc45044
update integ test
samson-keung 4e980a2
update SNS target integ test
samson-keung 3001fb0
update test with input logic update
samson-keung c8ef60d
update sqs target integ test
samson-keung 6d0c9c3
update LambdaInvoke integ test
samson-keung 9fc50c5
revert reducing key permissions
samson-keung d8992ee
revert integ.schedule.ts change
samson-keung 3f3e132
fix integ.schedule test
samson-keung fabef86
fix integ.schedule test
samson-keung 7c67ac0
fix integ.schedule test
samson-keung 455a092
update integ
samson-keung 550cc14
add unit test for input
samson-keung 404f0aa
Merge branch 'main' into scheduler-reduce-key-permissions
samson-keung 09521ad
Merge branch 'main' into scheduler-reduce-key-permissions
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 0 additions & 9 deletions
9
packages/@aws-cdk/aws-scheduler-alpha/test/integ.schedule.js.snapshot/manifest.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
...argets-alpha/test/integ.sns-publish.js.snapshot/AwsSchedulerTargetsSnsPublish.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 6 additions & 6 deletions
12
...eg.sns-publish.js.snapshot/IntegTestSnsPublishDefaultTestDeployAssert36D5D430.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is probably a better implementation approach but since this is only used internal/private in the class, I will fix the behaviour for now, then improve the design for easier readability and maintainability in subsequent PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its fine honestly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a similar class in
aws-events
where the second parameter is the inputType and the bind method handles the input accordingly. Could we do something similar here?