Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(merge-back): 2.164.1 #31910

Merged
merged 5 commits into from
Oct 25, 2024
Merged

chore(merge-back): 2.164.1 #31910

merged 5 commits into from
Oct 25, 2024

Commits on Oct 25, 2024

  1. fix: enable node-fips compatible body checksums for S3 (#31883) 

    Internal reference: D166315367

In FIPS enabled environments, the MD5 algorithm is not available for use in crypto module.
However by default the S3 client is using an MD5 checksum for content integrity checking.
This causes any S3 upload operation to fail with a cryptography error.

We are disabling the S3 content checksums, and are re-enabling the regular SigV4 body signing.
SigV4 uses SHA256 for their content checksum. This configuration matches the default behavior
of the AWS SDKv3 and is a safe choice for all users.

For non-FIPS users, we have verified functionality via cli-integ-tests.
For FIPS users, we have manually verified `cdk deploy` is now working in a FIPS enabled environment.
We have also verified the configuration with the affected customer.

- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @mrgrain
    mrgrain committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    290a499 View commit details
    Browse the repository at this point in the history

  2. chore(release): 2.164.1

    @mrgrain
    mrgrain committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    476fd96 View commit details
    Browse the repository at this point in the history

  3. chore(release): 2.164.1 (#31901) 

    See CHANGELOG
    @mergify
    mergify[bot] authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f99eb4e View commit details
    Browse the repository at this point in the history

  4. fix(cli): disable FIPS support for garbage collection 

    Some S3 APIs in SDKv2 have a bug that always requires them to use a MD5 checksum. GC is using them, so we will temporarily disable the feature in FIPS environments.
    @mrgrain
    mrgrain committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    bb9275c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into merge-back/2.164.1

    @mrgrain
    mrgrain authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e42cc02 View commit details
    Browse the repository at this point in the history