chore(cli): stops tests from interfering with each other #32319
Conversation
Turn on test randomization: this causes tests to run in a random order, which will expose tests that only succeed because tests before them have left the system in a specific state (or that poison tests after them because they don't clean up). Of course, doing this exposed that we have a number of such tests, clean those up as well. This needed to clean up mocking a lot in the garbage collector code, because it was confusing. Also remove the side-effect mock resetting that happens whenver a `MockSdk()` is instantiated, since that caused prepared mock behavior to be cleared.
rix0rrr
changed the title
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32319 +/- ##
==========================================
+ Coverage 78.19% 78.20% +0.01%
==========================================
Files 105 105
Lines 7177 7177
Branches 1318 1318
==========================================
+ Hits 5612 5613 +1
+ Misses 1377 1376 -1
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Turn on test randomization: this causes tests to run in a random order, which will expose tests that only succeed because tests before them have left the system in a specific state (or that poison tests after them because they don't clean up).
Of course, doing this exposed that we have a number of such tests, clean those up as well.
This needed to clean up mocking a lot in the garbage collector code, because it was confusing. Also remove the side-effect mock resetting that happens whenver a
MockSdk()is instantiated, since that caused prepared mock behavior to be cleared.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license