Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ecs-patterns): fix ec2/multiple-application-load-balanced-ecs-service integration test #32524

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

phuhung273
Copy link
Contributor

Issue # (if applicable)

Relate #32506

Reason for this change

This test is failing. Please try this quick check

docker run -d -p 80:80 -p 90:90 amazon/amazon-ecs-sample:latest

# Success
curl http://localhost:80

# Fail
curl http://localhost:90

Description of changes

  • Modify ECS task to also expose port 90
  • Migrate to LaunchTemplate as LaunchConfiguration cannot be used on new account

Description of how you validated changes

yarn integ test/aws-ecs-patterns/test/ec2/integ.multiple-application-load-balanced-ecs-service.js

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Dec 14, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 14, 2024 11:47
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (ec4b91b) to head (008e41b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32524   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files         236      236           
  Lines       14253    14253           
  Branches     2490     2490           
=======================================
  Hits        11522    11522           
  Misses       2446     2446           
  Partials      285      285           
Flag Coverage Δ
suite.unit 80.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.57% <ø> (ø)
packages/aws-cdk-lib/core 82.20% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 14, 2024
GavinZZ
GavinZZ previously approved these changes Feb 6, 2025
@GavinZZ
Copy link
Contributor

GavinZZ commented Feb 6, 2025

Thank you for this fix!

Copy link
Contributor

mergify bot commented Feb 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 6, 2025
Copy link
Contributor

mergify bot commented Feb 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Feb 7, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@aaythapa
Copy link
Contributor

aaythapa commented Feb 7, 2025

@mergify requeue

Copy link
Contributor

mergify bot commented Feb 7, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@aaythapa
Copy link
Contributor

aaythapa commented Feb 7, 2025

@mergify update

Copy link
Contributor

mergify bot commented Feb 7, 2025

update

☑️ Nothing to do

  • queue-position = -1 [📌 update requirement]
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

Copy link
Contributor

mergify bot commented Feb 7, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #32524 has been manually updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot dismissed GavinZZ’s stale review February 7, 2025 00:20

Pull request has been modified.

@aaythapa
Copy link
Contributor

aaythapa commented Feb 7, 2025

@mergify requeue

Copy link
Contributor

mergify bot commented Feb 7, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 008e41b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@moelasmar
Copy link
Contributor

@mergify requeue

Copy link
Contributor

mergify bot commented Feb 7, 2025

requeue

☑️ This pull request is already queued

@mergify mergify bot merged commit fd05c10 into aws:main Feb 7, 2025
22 checks passed
Copy link

github-actions bot commented Feb 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2025
@phuhung273 phuhung273 deleted the fix-ecs-pattern-integ branch February 7, 2025 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants