Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VpcV2): add BYOIP IPv6 to VPCv2 #32927

Merged
merged 7 commits into from
Jan 22, 2025
Merged

feat(VpcV2): add BYOIP IPv6 to VPCv2 #32927

merged 7 commits into from
Jan 22, 2025

Conversation

shikha372
Copy link
Contributor

@shikha372 shikha372 commented Jan 14, 2025

Issue # (if applicable)

Closes #.

Reason for this change

This PR adds new fields under VPCv2 construct to add BYOIP using AWS pool id and CIDR range of the IPv6 address.

Description of changes

Describe any new or updated permissions being added

No update to permissions.

Description of how you validated changes

Added unit test and integration test.
To test these changes in future, users will need to modify the pool-id with the one hosted in their account and run integration test.
For internal testing, instructions added to team-internal docs with pool onboarding details.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 14, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 14, 2025 22:37
@github-actions github-actions bot added the p2 label Jan 14, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.49%. Comparing base (c86296e) to head (704451a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32927   +/-   ##
=======================================
  Coverage   81.49%   81.49%           
=======================================
  Files         224      224           
  Lines       13755    13755           
  Branches     2413     2413           
=======================================
  Hits        11209    11209           
  Misses       2273     2273           
  Partials      273      273           
Flag Coverage Δ
suite.unit 81.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.85% <ø> (ø)
packages/aws-cdk-lib/core 82.15% <ø> (ø)

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 15, 2025 01:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@shikha372 shikha372 marked this pull request as ready for review January 15, 2025 04:32
@aws aws deleted a comment from aws-cdk-automation Jan 15, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 16, 2025
packages/@aws-cdk/aws-ec2-alpha/lib/vpc-v2.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ec2-alpha/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ec2-alpha/lib/util.ts Show resolved Hide resolved
packages/@aws-cdk/aws-ec2-alpha/lib/util.ts Show resolved Hide resolved
packages/@aws-cdk/aws-ec2-alpha/lib/vpc-v2.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ec2-alpha/lib/vpc-v2.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ec2-alpha/lib/vpc-v2.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ec2-alpha/lib/vpc-v2.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ec2-alpha/lib/vpc-v2.ts Outdated Show resolved Hide resolved
shikha372 and others added 2 commits January 21, 2025 10:55
Co-authored-by: paulhcsun <47882901+paulhcsun@users.noreply.github.com>
@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Jan 21, 2025

update

☑️ Nothing to do

  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Jan 22, 2025

update

✅ Branch has been successfully updated

@shikha372
Copy link
Contributor Author

@Mergifyio update

Copy link
Contributor

mergify bot commented Jan 22, 2025

update

☑️ Nothing to do

  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

Copy link
Contributor

mergify bot commented Jan 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 22, 2025
Copy link
Contributor

mergify bot commented Jan 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 704451a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jan 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 93c95fc into main Jan 22, 2025
20 checks passed
@mergify mergify bot deleted the byoip_ipv6 branch January 22, 2025 02:14
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants