chore(toolkit): list action #33298
chore(toolkit): list action #33298
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (88.23%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #33298 +/- ##
==========================================
- Coverage 80.83% 80.83% -0.01%
==========================================
Files 236 236
Lines 14253 14251 -2
Branches 2490 2490
==========================================
- Hits 11522 11520 -2
Misses 2446 2446
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
mrgrain
added
the
pr-linter/exempt-codecov
|
Exempting codecov patch coverage since the uncovered lines are refactors only. |
mrgrain
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
packages/@aws-cdk/toolkit/test/_fixtures/stack-with-bucket/index.js
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/toolkit/test/_fixtures/two-empty-stacks/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
These helpers are copied from the existing test setup in the CLI. I didn't touch them at all. After the repo split is complete we can move them into a shared file if we want to. Right now, we cannot.
There was a problem hiding this comment.
this is covering the same test cases as the cli test
| @@ -235,6 +254,45 @@ export class StackCollection { | |||
| return this.stackArtifacts.map(s => s.hierarchicalId); | |||
| } | |||
|
|
|||
| public withDependencies(): StackDetails[] { | |||
There was a problem hiding this comment.
This was a helper method exclusive to the list command. I've made it available on the also internal StackCollection class instead.
mrgrain
added
the
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mrgrain
force-pushed
the
mrgrain/chore/toolkit/list
branch
from
5ec402d to
5b76b18
Compare
mrgrain
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue #33179
Closes #33179
Description of changes
Adds the list action.
Converts the existing dependency calculation code into a generic feature on StackCollection.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Unit tests and integ test pipeline
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license