Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vpc): additional validation around Subnet Types #4668

Merged
merged 3 commits into from
Oct 27, 2019

Commits on Oct 24, 2019

  1. feat(vpc): additional validation around Subnet Types

    Try to improve the usability around VPCs and certain Subnet Type
    configurations.
    
    - Make clear that ISOLATED does not mean "no Internet access at all",
      just no Internet access from the point of view of the current VPC.
    
    - If people configure natGateways=0, tell them that they probably meant
      to configure no PRIVATE subnets.
    
    - If people DO configure PRIVATE subnets, make sure they also configure
      PUBLIC subnets, otherwise we won't be able to place the NAT gateways
      anywhere useful.
    
    - If people end up with a VPC without PRIVATE subnets, the default
      behavior of `selectSubnets` is pretty useless, because it can never
      work, and that's not what people are used to from the CDK. Dynamically
      adjust the selection default to whatever subnet types *are* available.
    
    Fixes #3704.
    rix0rrr committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    0a74433 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. Configuration menu
    Copy the full SHA
    e3053c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2019

  1. Configuration menu
    Copy the full SHA
    9f760eb View commit details
    Browse the repository at this point in the history