Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade jsii-pacmak to 1.3.1 #7420

Merged
merged 1 commit into from
Apr 18, 2020

Conversation

skinny85
Copy link
Contributor

Commit Message

chore: upgrade jsii-pacmak to 1.3.1

Version 1.3.0 of jsii-packmak has a bug that makes it impossible to publish .NET packages generated with it to NuGet. It was fixed in aws/jsii#1568, released in version 1.3.1, so change our yarn.lock file to use that latest version (fortunately, we use carets in the dependency declarations on jsii-pacmak).

End Commit Message


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 changed the base branch from master to release April 18, 2020 01:43
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 18, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c95554f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Version 1.3.0 of jsii-packmak has a bug that makes it impossible
to publish .NET packages generated with it to NuGet.
It was fixed in aws/jsii#1568,
released in version 1.3.1,
so change our yarn.lock file to use that latest version
(fortunately, we use carets in the dependency declarations on jsii-pacmak).
@skinny85 skinny85 force-pushed the hotfix/dotnet-1.33.0-release branch from c95554f to ef7cbad Compare April 18, 2020 02:10
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ef7cbad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 merged commit a52133f into aws:release Apr 18, 2020
@skinny85 skinny85 deleted the hotfix/dotnet-1.33.0-release branch April 18, 2020 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants