Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(certificatemanager): Update README to inline examples and mention limits #9800

Merged
merged 2 commits into from
Aug 18, 2020
Merged

chore(certificatemanager): Update README to inline examples and mention limits #9800

merged 2 commits into from
Aug 18, 2020

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Aug 18, 2020

Minor refactoring of the README to inline the examples (from the .lit.ts
files), and to explicitly call out the yearly certificate limit.

fixes #5889

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@njlynch
chore(certificatemanager): Update README to inline examples and menti…
9c2036d 
…on limits

Minor refactoring of the README to inline the examples (from the `.lit.ts`
files), and to explicitly call out the yearly certificate limit.

fixes #5889
@njlynch njlynch requested a review from a team August 18, 2020 15:51
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 18, 2020
@bvtujo bvtujo mentioned this pull request Aug 18, 2020
Closed
@shivlaks shivlaks added the pr/do-not-merge This PR should not be merged at this time. label Aug 18, 2020
shivlaks
shivlaks approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@njlynch njlynch removed the pr/do-not-merge This PR should not be merged at this time. label Aug 18, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 6c6e438
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ffb06ab into master Aug 18, 2020
@mergify mergify bot deleted the njlynch/acm-docs branch August 18, 2020 22:58
misterjoshua pushed a commit to misterjoshua/aws-cdk that referenced this pull request Aug 19, 2020
@njlynch @misterjoshua
chore(certificatemanager): Update README to inline examples and menti…
6f405c0 
…on limits (aws#9800)

Minor refactoring of the README to inline the examples (from the `.lit.ts`
files), and to explicitly call out the yearly certificate limit.

fixes aws#5889

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks approved these changes

Assignees

@njlynch njlynch

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs should warn about ACM yearly certificate limit
3 participants
@njlynch @aws-cdk-automation @shivlaks