Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloudfront): update README.md with examples on how to use pre-existing lambda@edge functions with cloudfront #9940

Merged

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Aug 24, 2020

Relates to #9901


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

nija-at
nija-at previously requested changes Sep 2, 2020
@robertd robertd force-pushed the robertd/update-import-lambda-edge-version-readme branch from 762c01c to 87c891e Compare September 2, 2020 14:36
@mergify mergify bot dismissed nija-at’s stale review September 2, 2020 14:36

Pull request has been modified.

@robertd robertd changed the title chore(lambda): update README.md with examples on how to use pre-existing lambda@edge functions with cloudfront chore(cloudfront): update README.md with examples on how to use pre-existing lambda@edge functions with cloudfront Sep 2, 2020
@nija-at nija-at assigned njlynch and unassigned nija-at Sep 2, 2020
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Two minor nitpicks.

Two stylistic changes.
njlynch
njlynch previously approved these changes Sep 2, 2020
@mergify mergify bot dismissed njlynch’s stale review September 2, 2020 17:37

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 43e129b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5c9e6f6 into aws:master Sep 2, 2020
@robertd robertd deleted the robertd/update-import-lambda-edge-version-readme branch January 28, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants